Skip to content

[UI] Fix export import after pr 467 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

senwang86
Copy link
Collaborator

Summary

  • Support html output in pod output display, see screenshot below
  • Fix exporting the repo in .ipynb format
  • Fix import .ipynb notebook
  • To-do:
    • Tune the pod size based on <img> size
    • Fix broken Rich pod export/import due to usage of yxml
    • Fix "Raw JSON" export function

Test

Screenshot 2023-08-24 at 9 49 26 PM

@senwang86 senwang86 requested a review from lihebi August 25, 2023 04:54
@lihebi
Copy link
Collaborator

lihebi commented Aug 25, 2023

To-do:

  • Tune the pod size based on <img> size

The image size should be adapted to the pod size, not vice versa. That was the case: if you plot a matplotlib figure on codepod.io, the figure adapts to fit the pod. It broke at some point.

  • Fix "Raw JSON" export function

A side note: as we discussed before, this should be done on the frontend. But more broadly speaking, we need to get a hold on this. This feature is meant to preserve a lossless data of a repo. Since we are using yjs, we need to store yjs content.

@lihebi
Copy link
Collaborator

lihebi commented Aug 25, 2023

The PR looks great, thanks!

@lihebi lihebi merged commit 50b2557 into codepod-io:main Aug 25, 2023
@senwang86
Copy link
Collaborator Author

The image size should be adapted to the pod size, not vice versa. That was the case: if you plot a matplotlib figure on codepod.io, the figure adapts to fit the pod. It broke at some point.

Agree, the matplotlib figure can be adjusted correctly. While the web images seems not, need some debug later.

A side note: as we discussed before, this should be done on the frontend. But more broadly speaking, we need to get a hold on this. This feature is meant to preserve a lossless data of a repo. Since we are using yjs, we need to store yjs content.

Yes, I am aware of this and will discuss the implementation later sometime. Just to put it in the to-do list.

@lihebi
Copy link
Collaborator

lihebi commented Aug 25, 2023

Agree, the matplotlib figure can be adjusted correctly.

Matplotlib figures are not adjusting now. I think it’s broken by #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants