Skip to content

fix annoying horizontal scroll bar in repos in dabshboard #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

forrestbao
Copy link
Collaborator

For issue #118

@forrestbao forrestbao requested a review from lihebi December 9, 2022 05:57
Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't seem to have used a formatted. If you are using VSCode, try to format these two files using Prettier.

@@ -21,7 +21,7 @@ interface form {
button?: any;
}

export default function CreateRepoForm(props: form = {}) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface form is unused now. Remove it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in the new line, I removed the type form and default value {} but left the props argument there for easy customization and control in the future. Good?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@lihebi
Copy link
Collaborator

lihebi commented Dec 9, 2022

Can you also give me permission to push to your branch, so that I can make these trivial tweaks as well?

@forrestbao
Copy link
Collaborator Author

Can you also give me permission to push to your branch, so that I can make these trivial tweaks as well?

Of course, invitation sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scroll bars
2 participants