Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Do not run relase-images on forked prs #366

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Do not run relase-images on forked prs #366

merged 3 commits into from
Aug 20, 2021

Conversation

f-moya
Copy link
Contributor

@f-moya f-moya commented Aug 10, 2021 •
edited
Loading

We are receiving failed builds from prs open by the community due to running the relase-images ci job. This work removes this job for those cases.

See #364

@f-moya f-moya closed this Aug 19, 2021
@f-moya f-moya reopened this Aug 19, 2021
@f-moya f-moya requested a review from filipesperandio August 19, 2021 22:28
filipesperandio
filipesperandio reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@filipesperandio filipesperandio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping CI for those, how we are going to validate them instead?

@f-moya
Copy link
Contributor Author

f-moya commented Aug 20, 2021 •
edited
Loading

Skipping CI for those, how we are going to validate them instead?

@filipesperandio it's not the entire ci, just the job for releasing images. Do you think releasing images is a necessary step for validating prs ?

@filipesperandio
Copy link
Contributor

🤦 I was tired...

filipesperandio
filipesperandio approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@filipesperandio filipesperandio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK shipping this anyways, but seems like we only actually release images for master and channel-* branches here: https://github.com/codeclimate/codeclimate-duplication/blob/master/bin/deploy#L10-L13

@f-moya
Copy link
Contributor Author

f-moya commented Aug 20, 2021 •
edited
Loading

I am OK shipping this anyways, but seems like we only actually release images for master and channel-* branches here: https://github.com/codeclimate/codeclimate-duplication/blob/master/bin/deploy#L10-L13

mmmm, interesting because it is getting triggered on #364

@f-moya f-moya force-pushed the ci/ignore-relase-on-forked-prs branch 2 times, most recently from 6205888 to 109177c Compare August 20, 2021 13:32
filipesperandio
filipesperandio approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@filipesperandio filipesperandio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that build seems to break on docker login, even before the bin/deploy call, but I agree this is even better as we skip the step entirely, have CIRCLE env vars checked on Circle related files and make it more visible.

👍

@f-moya
Copy link
Contributor Author

f-moya commented Aug 20, 2021

@filipesperandio Exactly it was breaking before the bin/deploy, could you merge it ? 🙏🏼

@filipesperandio filipesperandio merged commit 7af5f61 into master Aug 20, 2021
@filipesperandio filipesperandio deleted the ci/ignore-relase-on-forked-prs branch August 20, 2021 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesperandio filipesperandio filipesperandio approved these changes

Assignees

@filipesperandio filipesperandio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-moya @filipesperandio