Skip to content

chore(form-options-mixin): handle edge case where null/falsey passed to options prop #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2020
Merged

chore(form-options-mixin): handle edge case where null/falsey passed to options prop #5146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a312bf0
chore(form-options-mixin): handle edge case where null/undefined/fals…
tmorehouse Apr 14, 2020
ce79e0f
Update form-options.js
tmorehouse Apr 14, 2020
9751a6c
Update form-options.js
tmorehouse Apr 14, 2020
4b2a6db
Update form-options.js
tmorehouse Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/mixins/form-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@ export default {
// Normalize the given options array
if (isArray(options)) {
return options.map(option => this.normalizeOption(option))
} else if (isPlainObject(options)) {
// Deprecate the object options format
warn(OPTIONS_OBJECT_DEPRECATED_MSG, this.$options.name)
// Normalize a `options` object to an array of options
return keys(options).map(key => this.normalizeOption(options[key] || {}, key))
}
// Deprecate the object options format
warn(OPTIONS_OBJECT_DEPRECATED_MSG, this.$options.name)
// Normalize a `options` object to an array of options
return keys(options).map(key => this.normalizeOption(options[key] || {}, key))
// If not an array or object, return an empty array
/* istanbul ignore next */
return []
}
},
methods: {
Expand Down