bootstrap-vue · jacobmllr95 · Sep 9, 2019 · Sep 8, 2019 · Sep 8, 2019 · Sep 8, 2019
diff --git a/docs/nuxt.config.js b/docs/nuxt.config.js
@@ -179,11 +179,17 @@ module.exports = {
     height: '3px'
   },
 
-  manifest: {
-    name: 'BootstrapVue',
-    short_name: 'BootstrapVue',
-    description: 'Quickly integrate Bootstrap v4 components with Vue.js',
-    theme_color: '#563d7c'
+  pwa: {
+    icon: {
+      // iconFileName: 'icon.png',
+      iconSrc: '~/static/icon.png'
+    },
+    manifest: {
+      name: 'BootstrapVue',
+      short_name: 'BootstrapVue',
+      description: 'Quickly integrate Bootstrap v4 components with Vue.js',
+      theme_color: '#563d7c'
+    }
   },
 
   generate: {

diff --git a/package.json b/package.json
@@ -78,14 +78,14 @@
     "vue-functional-data-merge": "^3.1.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.5.5",
-    "@babel/core": "^7.5.5",
-    "@babel/plugin-transform-modules-commonjs": "^7.5.0",
-    "@babel/plugin-transform-runtime": "^7.5.5",
-    "@babel/preset-env": "^7.5.5",
-    "@babel/standalone": "^7.5.5",
+    "@babel/cli": "^7.6.0",
+    "@babel/core": "^7.6.0",
+    "@babel/plugin-transform-modules-commonjs": "^7.6.0",
+    "@babel/plugin-transform-runtime": "^7.6.0",
+    "@babel/preset-env": "^7.6.0",
+    "@babel/standalone": "^7.6.0",
     "@nuxtjs/google-analytics": "^2.2.0",
-    "@nuxtjs/pwa": "^3.0.0-beta.16",
+    "@nuxtjs/pwa": "^3.0.0-beta.17",
     "@vue/test-utils": "^1.0.0-beta.29",
     "autoprefixer": "^9.6.1",
     "babel-core": "^7.0.0-bridge.0",
@@ -123,15 +123,15 @@
     "nuxt": "^2.9.2",
     "postcss-cli": "^6.1.3",
     "prettier": "1.14.3",
-    "rollup": "^1.20.3",
+    "rollup": "^1.21.0",
     "rollup-plugin-babel": "^4.3.3",
     "rollup-plugin-commonjs": "^10.1.0",
     "rollup-plugin-node-resolve": "^5.2.0",
     "sass-loader": "^8.0.0",
     "standard-version": "^7.0.0",
-    "terser": "^4.2.1",
+    "terser": "^4.3.0",
     "vue": "^2.6.10",
-    "vue-jest": "^3.0.4",
+    "vue-jest": "^3.0.5",
     "vue-router": "^3.1.3",
     "vue-server-renderer": "^2.6.10",
     "vue-template-compiler": "^2.6.10"

diff --git a/src/components/modal/helpers/bv-modal.js b/src/components/modal/helpers/bv-modal.js
@@ -79,10 +79,11 @@ const plugin = Vue => {
       // Self destruct after hidden
       this.$once('hidden', handleDestroy)
       // Self destruct on route change
-      /* istanbul ignore next */
+      /* istanbul ignore if */
       if (this.$router && this.$route) {
-        const unwatch = this.$watch('$router', handleDestroy)
-        this.$once('hook:beforeDestroy', unwatch)
+        // Destroy ourselves if route changes
+        /* istanbul ignore next */
+        this.$once('hook:beforeDestroy', this.$watch('$router', handleDestroy))
       }
       // Show the `BMsgBox`
       this.show()

diff --git a/src/components/modal/modal.js b/src/components/modal/modal.js
@@ -453,6 +453,7 @@ export const BModal = /*#__PURE__*/ Vue.extend({
         /* istanbul ignore next */
         return
       }
+      /* istanbul ignore next */
       if (this.isClosing) {
         // If we are in the process of closing, wait until hidden before re-opening
         /* istanbul ignore next */

diff --git a/src/components/pagination-nav/pagination-nav.js b/src/components/pagination-nav/pagination-nav.js
@@ -25,9 +25,8 @@ const props = {
   numberOfPages: {
     type: [Number, String],
     default: 1,
-    validator(value) {
+    validator(value) /* istanbul ignore next */ {
       const num = parseInt(value, 10)
-      /* istanbul ignore next */
       if (isNaN(num) || num < 1) {
         warn('b-pagination: prop "number-of-pages" must be a number greater than 0')
         return false

diff --git a/src/components/table/helpers/mixin-provider.js b/src/components/table/helpers/mixin-provider.js
@@ -153,16 +153,18 @@ export default {
           } else if (isArray(data)) {
             // Provider returned Array data
             this._providerSetLocal(data)
-          } else if (this.items.length !== 2) {
-            // Check number of arguments provider function requested
-            // Provider not using callback (didn't request second argument), so we clear
-            // busy state as most likely there was an error in the provider function
-            /* istanbul ignore next */
-            warn(
-              "b-table provider function didn't request callback and did not return a promise or data"
-            )
-            /* istanbul ignore next */
-            this.localBusy = false
+          } else {
+            /* istanbul ignore if */
+            if (this.items.length !== 2) {
+              // Check number of arguments provider function requested
+              // Provider not using callback (didn't request second argument), so we clear
+              // busy state as most likely there was an error in the provider function
+              /* istanbul ignore next */
+              warn(
+                "b-table provider function didn't request callback and did not return a promise or data"
+              )
+              this.localBusy = false
+            }
           }
         } catch (e) /* istanbul ignore next */ {
           // Provider function borked on us, so we spew out a warning

diff --git a/src/components/toast/toast.js b/src/components/toast/toast.js
@@ -203,6 +203,7 @@ export const BToast = /*#__PURE__*/ Vue.extend({
     // Make sure we hide when toaster is destroyed
     /* istanbul ignore next: difficult to test */
     this.listenOnRoot('bv::toaster::destroyed', toaster => {
+      /* istanbul ignore next */
       if (toaster === this.computedToaster) {
         /* istanbul ignore next */
         this.hide()

diff --git a/src/components/tooltip/helpers/bv-tooltip.js b/src/components/tooltip/helpers/bv-tooltip.js
@@ -407,6 +407,7 @@ export const BVTooltip = /*#__PURE__*/ Vue.extend({
       /* istanbul ignore next: ignore for now */
       if (hideEvt.defaultPrevented) {
         // Don't hide if event cancelled
+        /* istanbul ignore next */
         return
       }
 

diff --git a/src/mixins/pagination.js b/src/mixins/pagination.js
@@ -53,9 +53,8 @@ export const props = {
   value: {
     type: [Number, String],
     default: null,
-    validator(value) {
+    validator(value) /* istanbul ignore next */ {
       const num = parseInt(value, 10)
-      /* istanbul ignore next */
       if (!isNull(value) && (isNaN(num) || num < 1)) {
         warn('pagination: v-model value must be a number greater than 0')
         return false
@@ -66,9 +65,8 @@ export const props = {
   limit: {
     type: [Number, String],
     default: DEFAULT_LIMIT,
-    validator(value) {
+    validator(value) /* istanbul ignore next */ {
       const num = parseInt(value, 10)
-      /* istanbul ignore next */
       if (isNaN(num) || num < 1) {
         warn('pagination: prop "limit" must be a number greater than 0')
         return false