-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(dropdown): support 'href', 'to' and 'variant' in split button mode (Closes #1960) #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support for `href` and/or `to` on the split button. Only applicable when dropdown is in split mode. Closes #1960
Codecov Report
@@ Coverage Diff @@
## dev #2301 +/- ##
=========================================
+ Coverage 67.1% 67.15% +0.05%
=========================================
Files 162 162
Lines 3213 3218 +5
Branches 892 894 +2
=========================================
+ Hits 2156 2161 +5
Misses 778 778
Partials 279 279
Continue to review full report at Codecov.
|
What about split variant? |
Split variant is in there... allows the split button to have its own variant (defaults to the same variant as the toggle) |
Description of Pull Request:
Add support for
href
and/orto
, as well asvariant
on the split button.New props:
split-href
split-to
split-variant
(defaults to same value asvariant
)Only applicable when dropdown is in
split
mode.Closes #1960
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: