Skip to content

feat(dropdown): support 'href', 'to' and 'variant' in split button mode (Closes #1960) #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 16, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 16, 2018

Description of Pull Request:

Add support for href and/or to, as well as variant on the split button.

New props:

  • split-href
  • split-to
  • split-variant (defaults to same value as variant)

Only applicable when dropdown is in split mode.

Closes #1960

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Add support for `href` and/or `to` on the split button.

Only applicable when dropdown is in split mode.

Closes #1960
@tmorehouse tmorehouse changed the title feat(dropdown): support 'href' and/or 'to' in split button mode (Closes #1960) feat(dropdown): support 'href' and 'to' in split button mode (Closes #1960) Dec 16, 2018
@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #2301 into dev will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #2301      +/-   ##
=========================================
+ Coverage   67.1%   67.15%   +0.05%     
=========================================
  Files        162      162              
  Lines       3213     3218       +5     
  Branches     892      894       +2     
=========================================
+ Hits        2156     2161       +5     
  Misses       778      778              
  Partials     279      279
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afba6c...096b9ef. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(dropdown): support 'href' and 'to' in split button mode (Closes #1960) feat(dropdown): support 'href', 'to' and 'variant' in split button mode (Closes #1960) Dec 16, 2018
@jacobmllr95
Copy link
Member

What about split variant?

@tmorehouse tmorehouse mentioned this pull request Dec 16, 2018
89 tasks
@tmorehouse
Copy link
Member Author

Split variant is in there... allows the split button to have its own variant (defaults to the same variant as the toggle)

@tmorehouse tmorehouse merged commit 31b7d19 into dev Dec 16, 2018
@tmorehouse tmorehouse deleted the tmorehouse/dd-split branch December 16, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-dropdown split link
2 participants