Skip to content

fix(dropdown): Item click event #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

#2140 added the onFocusOut handler to the focusout event of the .dropdown-menu. This caused an issue on some browsers (e.g. Safari) that the click event on the .dropdown-item wasn't fired anymore.

This PR adds a minimal timeout before setting visible to false which allows all browsers to handle the click event before hiding the menu.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2251 into dev will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##            dev    #2251      +/-   ##
========================================
+ Coverage    66%   66.01%   +0.01%     
========================================
  Files       158      158              
  Lines      3062     3063       +1     
  Branches    846      846              
========================================
+ Hits       2021     2022       +1     
  Misses      760      760              
  Partials    281      281
Impacted Files Coverage Δ
src/mixins/dropdown.js 3.92% <0%> (-0.04%) ⬇️
src/components/alert/alert.js 100% <0%> (ø) ⬆️
src/components/form-file/form-file.js 11.25% <0%> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <0%> (ø) ⬆️
src/components/form-input/form-input.js 100% <0%> (ø) ⬆️
src/components/input-group/input-group.js 100% <0%> (ø) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 78.57% <0%> (ø) ⬆️
src/components/form-radio/form-radio-group.js 78.57% <0%> (ø) ⬆️
src/components/table/table.js 74.87% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8406dcd...441f803. Read the comment docs.

@tmorehouse tmorehouse merged commit e620e07 into bootstrap-vue:dev Dec 7, 2018
@jacobmllr95 jacobmllr95 deleted the fix-dropdown-item-click-event branch December 8, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants