Skip to content

feat(forms): add form prop to all inputs. fixes #2154 #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 14, 2018
Merged

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

form controls that are wrapped in other elements internally were not transferring the form attribute to the input.

The form attribute allows a form control to specify which form it belongs to.

fixes #2154

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

form controls that are wrapped in other elements internally were not transferring the form attribute to the input.

fixes #2154
add form attribute
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2172 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2172      +/-   ##
==========================================
+ Coverage   65.93%   65.94%   +0.01%     
==========================================
  Files         158      158              
  Lines        3003     3004       +1     
  Branches      835      836       +1     
==========================================
+ Hits         1980     1981       +1     
  Misses        741      741              
  Partials      282      282
Impacted Files Coverage Δ
src/components/form-select/form-select.js 61.11% <ø> (ø) ⬆️
src/components/form-textarea/form-textarea.js 50% <ø> (ø) ⬆️
src/components/form-file/form-file.js 11.25% <ø> (ø) ⬆️
src/components/form-radio/form-radio-group.js 78.57% <ø> (ø) ⬆️
src/components/form-checkbox/form-checkbox.js 39.02% <ø> (ø) ⬆️
src/components/form-input/form-input.js 100% <ø> (ø) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 78.57% <ø> (ø) ⬆️
src/components/form-radio/form-radio.js 53.84% <ø> (ø) ⬆️
src/mixins/form-radio-check.js 65.51% <100%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab44375...8d214c4. Read the comment docs.

@tmorehouse tmorehouse merged commit 6009d72 into dev Nov 14, 2018
@tmorehouse tmorehouse deleted the tmorehouse/forms branch November 14, 2018 02:19
@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form attribute
1 participant