-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(forms): add form prop to all inputs. fixes #2154 #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
form controls that are wrapped in other elements internally were not transferring the form attribute to the input. fixes #2154
add form attribute
Codecov Report
@@ Coverage Diff @@
## dev #2172 +/- ##
==========================================
+ Coverage 65.93% 65.94% +0.01%
==========================================
Files 158 158
Lines 3003 3004 +1
Branches 835 836 +1
==========================================
+ Hits 1980 1981 +1
Misses 741 741
Partials 282 282
Continue to review full report at Codecov.
|
add form attribute
add form attribute
add form attribute
add form attribute
add form attribute
add form attribute
add form attribute
add some basic tests
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
form controls that are wrapped in other elements internally were not transferring the form attribute to the input.
The form attribute allows a form control to specify which form it belongs to.
fixes #2154
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: