fix(form-input): bug fixes and add new features #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2100 +/- ##
==========================================
- Coverage 64.61% 64.58% -0.03%
==========================================
Files 154 156 +2
Lines 2922 2948 +26
Branches 805 809 +4
==========================================
+ Hits 1888 1904 +16
- Misses 744 755 +11
+ Partials 290 289 -1
Continue to review full report at Codecov.
|
By dynamically adding/removing listeners as needed
tmorehouse
changed the title
tmorehouse
changed the title
Exposes input properties and methods for form inputs
Mixin for exposing the form input's validity properties and methods.
Add ID to no-wheel input
Add tests for no-wheel prop
Document events
tmorehouse
changed the title
|
This is GREAT @tmorehouse ❤️ |
|
Took a while to get used to the new Vue Test Utils, but I like it. |
This was referenced Nov 5, 2018
This was referenced Nov 14, 2018
|
Hello. Is this fix in bootstrap-vue@2.0.0-rc.11? |
|
It is currently only available in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes should address some of the issues reported with b-form-input:
fixes #2061, fixes #1988, fixes #1951, fixes #1881, fixes #1863, fixes #1855, fixes #1852, #fixes #1642
May address #2098, #1908, #1518, #2104 , #2131, #2124
Adds new
no-wheelprop to disable mouse wheel incrementing number inputs. (fixes #1872)Adds new mixins for exposing native
<input>selection (fixes #2026), range and validity on the component. Also addsfocusandblurmethods.Additional tests added.
Similar changes could be made with
b-form-textareaonce this PR is merged.