Skip to content

fix(b-alert): add dismissible check for dismiss btn #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

alexsasharegan
Copy link
Member

@alexsasharegan alexsasharegan commented Sep 7, 2017

Fixes #1007

@codecov-io
Copy link

Codecov Report

Merging #1008 into alpha will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##            alpha    #1008   +/-   ##
=======================================
  Coverage   38.67%   38.67%           
=======================================
  Files          69       69           
  Lines        2379     2379           
  Branches      686      685    -1     
=======================================
  Hits          920      920           
  Misses       1302     1302           
  Partials      157      157
Impacted Files Coverage Δ
lib/components/alert.vue 61.53% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 738c0be...8e0926c. Read the comment docs.

@alexsasharegan alexsasharegan merged commit c55d4ca into alpha Sep 7, 2017
@alexsasharegan alexsasharegan deleted the fix/alpha-alert branch September 7, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants