Skip to content

实现部分硬件平台接口 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2016
Merged

Conversation

fuqiangdong01
Copy link

实现部分硬件平台接口

@binarywang binarywang merged commit c0a3259 into binarywang:develop Dec 15, 2016
* Created by keungtung on 10/12/2016.
*/
public class BaseResp extends AbstractDeviceBean{
private BaseInfo base_info;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种不规范的命名能否做个重构?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您是说变量名中有下划线,而没有使用驼峰命名?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没错

@binarywang
Copy link
Owner

http://sonar.oschina.net/dashboard/index/weixin-java-tools-1094677 你可以参考下这个,里面提到了所有代码存在的问题,其中也有你刚提交的代码,你看是否方便修正下?

@fuqiangdong01
Copy link
Author

当然可以。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants