Skip to content

Bug fix/bts 2174 async prefetch with kill (#21861) #21864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.12.5
Choose a base branch
from

Conversation

mchacki
Copy link
Member

@mchacki mchacki commented Jul 17, 2025

Backport of #21861

Scope & Purpose

Fixes a race condition in async query execution, while the query is getting killed. This race did cause the kill process to get stuck

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

* Added a test and the bugfix implementation for a query that gets killed during async prefetching

* Added CHANGELOG entry

* Update arangod/Aql/ExecutionBlockImpl.h

Co-authored-by: Max Neunhöffer <max@arangodb.com>

* Fixed clang format

* Clarified changelog entry

* Fixed try finally clause in test.

* Added more clarification to AsyncPrefetch comment

* Applied clangformat changes. Fixed batchsize on streaming cursor

---------

Co-authored-by: Max Neunhöffer <max@arangodb.com>
@mchacki mchacki requested a review from goedderz July 17, 2025 07:48
@mchacki mchacki self-assigned this Jul 17, 2025
@mchacki mchacki added the 1 Bug label Jul 17, 2025
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2025
@mchacki mchacki requested a review from neunhoef July 17, 2025 08:14
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants