Call channel initializer when using async methods on pipe bootstrap #3309
+224
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: For our async initializers on bootstraps, it's imortant that _both_ channel initializers are called, not only the one that comes as an argument on the bind function. Modifications: Fix the takeOwnershipOfDescriptor async functions to call the initializer from the bootstrap, and add regression tests. Result: Better behaved code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For our async initializers on bootstraps, it's imortant that both channel initializers are called, not only the one that comes as an argument on the bind function.
Modifications:
Fix the takeOwnershipOfDescriptor async functions to call the initializer from the bootstrap, and add regression tests.
Result:
Better behaved code.