Skip to content

Arm32 v8m support cmake clang compile #16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025
Merged

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Jun 26, 2025

Note: Please adhere to Contributing Guidelines.

Summary

Fix some errors and add cmake clang compilation check for armv8m in ci

  1. arm32-v8m/cmake-clang: Fix clang's error in specifying cfg and target
  2. arm32/clang-cmake: nuttx_find_toolchain_lib moved to a common location
  3. compiler-rt/cmake: Fix compilation error, the target is wrong
  4. mps3-an547/gcov: Compile with clang using cmake in ci

Impact

None

Testing

ci

@github-actions github-actions bot added Area: Tooling Area: CI Arch: arm Issues related to ARM (32-bit) architecture Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Jun 26, 2025
@jerpelea jerpelea requested review from anchao and raiden00pl and removed request for anchao June 26, 2025 12:09
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use
arch/ in the commit title

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for c6dbc8a
please use as title
tools/ci: Compile mps3-an547/gcov with clang using cmake in ci

acassis
acassis previously approved these changes Jun 26, 2025
@W-M-R
Copy link
Contributor Author

W-M-R commented Jun 27, 2025

for c6dbc8a please use as title tools/ci: Compile mps3-an547/gcov with clang using cmake in ci

ok

@W-M-R
Copy link
Contributor Author

W-M-R commented Jun 27, 2025

The modification to compile ci cmake clang does not seem to have taken effect. How can I make the necessary changes?

jerpelea
jerpelea previously approved these changes Jun 27, 2025
@xiaoxiang781216
Copy link
Contributor

@W-M-R W-M-R dismissed stale reviews from jerpelea and acassis via 546c886 June 27, 2025 13:02
@W-M-R W-M-R force-pushed the arm32-clang branch 2 times, most recently from 546c886 to 2a2a3a8 Compare July 1, 2025 04:10
xiaoxiang781216
xiaoxiang781216 previously approved these changes Jul 1, 2025
jerpelea
jerpelea previously approved these changes Jul 2, 2025
@xiaoxiang781216
Copy link
Contributor

@W-M-R please fix the build break.

@W-M-R W-M-R dismissed stale reviews from jerpelea and xiaoxiang781216 via 7ed6ab4 July 11, 2025 07:14
@W-M-R
Copy link
Contributor Author

W-M-R commented Jul 11, 2025

@W-M-R please fix the build break.

OK

@github-actions github-actions bot added the Size: S The size of the change in this PR is small label Jul 11, 2025
W-M-R added 4 commits July 17, 2025 16:09
1. -target should be in front, otherwise clang will not be able to find the corresponding libgcc.a
2. When using clang++ compiler to link, you also need to specify the corresponding arch, otherwise ld.lld will report an error due to arch mismatch.

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
The target is wrong

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
armv8m ci:
1. use makefile clang: /arm/mps/mps3-an547/configs/clang,CONFIG_ARM_TOOLCHAIN_CLANG
2. use cmake clang: CMAKE,mps3-an547:gcov

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add commit messages

@xiaoxiang781216 xiaoxiang781216 merged commit cbdc1a4 into apache:master Jul 18, 2025
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: CI Area: OS Components OS Components issues Area: Tooling Size: M The size of the change in this PR is medium Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants