Skip to content

Snowflake: CREATE DYNAMIC TABLE #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yoavcloud
Copy link
Contributor

Added support for CREATE DYNAMIC TABLE in Snowflake:

  1. Extended CreateTableBuilder with new options
  2. Removed the CreateTableBuilder::validate_schema_info function and related tests because, in my opinion, it introduces semantic validation, which is out of scope for the parser.
  3. As so many options exist for creating tables, we should evaluate whether specifying them explicitly is robust enough, or a generic parsing of options is a better alternative. Food for thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant