Snowflake: Support IDENTIFIER for GRANT ROLE #1957
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 21, 2025
There was a problem hiding this comment.
@yoavcloud double checking the intent is to add ObjectName support rather than Identifier as the MR description mentions?
| @@ -6623,7 +6623,7 @@ pub enum Action { | |||
| Replicate, | |||
| ResolveAll, | |||
| Role { | |||
| role: Ident, | |||
| role: ObjectName, | |||
There was a problem hiding this comment.
Could we add a test that uses a qualified name when mentioning the role? e.g. GRANT ROLE a.b.c to role d.e.f
There was a problem hiding this comment.
I added it in tests/sqlparser_snowflake.rs using the IDENTIFIER function. Qualified role names are not allowed in Snowflake (only database roles can be qualified).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.