Skip to content

Modernize cmake scripts and support MSVC 2017 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2018
Merged

Modernize cmake scripts and support MSVC 2017 #1

merged 3 commits into from
Apr 2, 2018

Conversation

btolfa
Copy link

@btolfa btolfa commented Mar 31, 2018

  • Added fixes for MSVC 2017 and Boost 1.66.0
  • Modernized cmake scripts (cmake 3.0 style)
  • Added proper cmake targets - cppnetlib::cppnetlib, cppnetlib::uri, etc.
    These targets keep usage requirements like flags, definitions, include directories, a library location and library dependences.

With these targets you can replace the following cmake script:

target_include_directories(MyTarget ${CPPNETLIB_INCLUDE_DIRS})
target_link_libraries(MyTarget ${CPPNETLIB_LIBRARIES})
target_compile_definitions(MyTarget BOOST_NETWORK_ENABLE_HTTPS)

with

target_link_libraries(MyTarget cppnetlib::uri)

btolfa added 3 commits March 31, 2018 13:55
@btolfa
Build: Clean up and modernize cmake scripts
2cb82ec
@btolfa
Build: fix build with Boost 1.66.0
cbb10e6
@btolfa
Work around ambiguous true_type
4a202d3 
Visual Studio 2017 cannot decide if it is

  boost::integral_constant<bool,true> boost::true_type

or

  boost::spirit::true_type

cpp-netlib@a5252b9
@btolfa btolfa mentioned this pull request Mar 31, 2018
Merged
@anonimal anonimal merged commit 4a202d3 into anonimal:0.13-release Apr 2, 2018
anonimal added a commit that referenced this pull request Apr 2, 2018
@anonimal
Merge pull request #1
604d50e 
4a202d3 Work around ambiguous true_type (Tengiz Sharafiev)
cbb10e6 Build: fix build with Boost 1.66.0 (Tengiz Sharafiev)
2cb82ec Build: Clean up and modernize cmake scripts (Tengiz Sharafiev)
@anonimal anonimal mentioned this pull request Apr 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btolfa @anonimal