Skip to content

Add dynamic suite #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

tetienne
Copy link
Contributor

@tetienne tetienne commented Oct 21, 2020

Context

Currently is not obvious how to add dynamically a test to a suite or parent suite or sub-suite. We have to the label function which is not obvious when you don't look at the code.

Checklist

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2020

CLA assistant check
All committers have signed the CLA.

@sseliverstov
Copy link
Contributor

@tetienne Thank you for your PR!

Please, fix test:
src/_allure.py:140:1: E302 expected 2 blank lines, found 1

@tetienne
Copy link
Contributor Author

@sseliverstov Yes indeed, I fixed it. Usually, I run tox on my machine.
I just discovered right now looking at the github workflow how you use it for this project.

@tetienne
Copy link
Contributor Author

@sseliverstov Can you please have a look to this PR?

@sseliverstov sseliverstov merged commit 8df0466 into allure-framework:master Oct 29, 2020
@tetienne tetienne deleted the AddDynamicSuite branch October 29, 2020 09:20
@tetienne tetienne mentioned this pull request Nov 3, 2020
2 tasks
skhomuti pushed a commit to skhomuti/allure-python that referenced this pull request Nov 18, 2020
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants