Added ability to freeze multiple directories; freeze neopixel library in cpx build #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e directories. Modules to freeze are included as git submodules.
tannewt
reviewed
Aug 23, 2017
.gitmodules
Outdated
| @@ -17,3 +17,6 @@ | |||
| [submodule "tools/uf2"] | |||
| path = tools/uf2 | |||
| url = https://github.com/Microsoft/uf2.git | |||
| [submodule "atmel-samd/frozen/Adafruit_CircuitPython_NeoPixel"] | |||
| path = atmel-samd/frozen/Adafruit_CircuitPython_NeoPixel | |||
There was a problem hiding this comment.
Would it make more sense to have these in the top level? They should have an API that works across all ports.
There was a problem hiding this comment.
Good point. I didn't do that initially because FROZEN_MPY_DIRS isn't implemented in all the ports. But it will be implemented in most or all of our ports eventually.
Changed and tested on a CPX.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze neopixel library in CPX build.
In order to generalize this:
Added ability to freeze multiple directories. Modules to freeze are included as git submodules. Submodules do not need to be duplicated if they are used for multiple builds.
In addition to
FROZEN_MPY_DIR, there is now aFROZEN_MPY_DIRSvariable, which includesFROZEN_MPY_DIRfor backwards compatibility. Modules to freeze for a particular board can be specified inmpconfigboard.mkfor that board by definingFROZEN_MPY_DIRSIn the process, reworked
py/mkrules.mkrules to build frozen modules in a more straightforward way.Cleanup: fix odd
$(BUILD)/$(BUILD)subdirectory structure that showed up for frozen modules.