Skip to content

updated llama.cpp to b2861 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

updated llama.cpp to b2861 #1449

wants to merge 1 commit into from

Conversation

Man2Dev
Copy link

@Man2Dev Man2Dev commented May 12, 2024

fixes cmake bug

@abetlen
Copy link
Owner

abetlen commented May 13, 2024

@Man2Dev thank you for the contribution however I usually handle the submodule updates just so I can manually review the upstream changes.

As for the issue, I see there's a fix for the version check, was it failing to set the correct cmake min version requirement?

@Man2Dev
Copy link
Author

Man2Dev commented May 13, 2024

@Man2Dev thank you for the contribution however I usually handle the submodule updates just so I can manually review the upstream changes.

As for the issue, I see there's a fix for the version check, was it failing to set the correct cmake min version requirement?

I didn't check i was trying to update the python-llama-cpp package in fedora and saw fix come in right after the submodule update so i thought i would point it out.

@abetlen
Copy link
Owner

abetlen commented May 14, 2024

@Man2Dev appreciate it

@abetlen abetlen closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants