Code optimisations for PHP8 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Feb 3, 2023
| @@ -227,7 +227,7 @@ public function unlock(Request $request): bool | |||
|
|
|||
| try { | |||
| $this->locks[$cacheKey]->release(); | |||
| } catch (LockReleasingException $e) { | |||
There was a problem hiding this comment.
| @@ -100,7 +100,7 @@ public function __construct(array $options = []) | |||
| $this->options = $resolver->resolve($options); | |||
| $this->cache = $this->options['cache']; | |||
| $this->lockFactory = $this->options['lock_factory']; | |||
| $this->hashAlgorithm = version_compare(PHP_VERSION, '8.1.0', '>=') ? 'xxh128' : 'sha256'; | |||
| $this->hashAlgorithm = \PHP_VERSION_ID >= 80100 ? 'xxh128' : 'sha256'; | |||
There was a problem hiding this comment.
The expression is evaluated by the compiler.
| @@ -508,13 +508,13 @@ private function restoreResponse(array $cacheData): ?Response | |||
|
|
|||
| // BC | |||
| if (\is_string($value)) { | |||
| $value = ['expires' => 0, 'contents' => $value]; | |||
There was a problem hiding this comment.
The key expires is not used.
|
LGTM, wdyt @alexander-schranz? |
alexander-schranz
approved these changes
Feb 6, 2023
|
Looks fine from my side the only case I have not enough knowledge about is the deletion of |
That's indeed not needed :) Thanks @GromNaN - released as 4.1.1: https://github.com/Toflar/psr6-symfony-http-cache-store/releases/tag/4.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose this minor changes, mostly suggested by PHPStorm.