Skip to content

refactor: Refactor SJFScheduling and Tests #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2025

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 12, 2025

  • Refactored manual test initializations with @ParameterizedTest using @MethodSource

  • Removed repetitive initialisationX() methods

  • Centralized test data for better readability and scalability

  • Added getProcesses() method in SJFScheduling for test inspection

  • Preserved existing test assertions with cleaner structure

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (dba2d86) to head (750ecea).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6372      +/-   ##
============================================
- Coverage     74.64%   74.62%   -0.02%     
+ Complexity     5448     5443       -5     
============================================
  Files           682      682              
  Lines         19012    18999      -13     
  Branches       3672     3668       -4     
============================================
- Hits          14191    14178      -13     
  Misses         4262     4262              
  Partials        559      559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alxkm alxkm changed the title refactor: Refactor SJFScheduling and Tests refactor: Refactor SJFScheduling and Tests Jul 12, 2025
Copy link
Collaborator

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@DenizAltunkapan DenizAltunkapan merged commit 910d5b8 into TheAlgorithms:master Jul 13, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants