allow completely empty configuration #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
styleci fail seems unrelated to my change. |
|
Thank you for this PR. |
Nyholm
approved these changes
Mar 2, 2018
|
could you please tag a new release with this fix? |
|
I will release 3.1.1 and 4.0 with this fix. Ill try to do it later today. We've already merged some BC breaking changes to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have a configuration test where i test that a completely empty configuration is accepted. this test started failing when i updated vendors: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/187362f0377bf272473fd3bbf113195939ebab82/tests/Unit/DependencyInjection/ConfigurationTest.php#L33
i investigated what the configuration is, and instead of an array there is
falsein the array. with this change, the test works for me.i don't know exactly where this is coming from or if its a behaviour change for empty configuration in symfony.