Skip to content

Add NoWarn NU1605 to System.ServiceModel.* #25219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Mar 23, 2025

PR Summary

This pull request includes an update to the src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj file to address a warning related to package references. The primary change involves adding a NoWarn attribute to several PackageReference elements.

Package reference updates:

  • Added NoWarn="NU1605" to the PackageReference elements for System.ServiceModel.Duplex, System.ServiceModel.Http, System.ServiceModel.NetTcp, System.ServiceModel.Primitives, System.ServiceModel.Security, and System.Private.ServiceModel to suppress warning NU1605.

PR Context

PR Checklist

@TravisEz13 TravisEz13 requested a review from a team as a code owner March 23, 2025 01:12
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2025
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@TravisEz13 TravisEz13 merged commit 86432d0 into master Mar 24, 2025
41 of 44 checks passed
@TravisEz13 TravisEz13 deleted the TravisEz13-patch-4 branch March 24, 2025 17:51
Copy link
Contributor

microsoft-github-policy-service bot commented Mar 24, 2025

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants