Skip to content

Make sure the vPack pipeline does not produce an empty package #24988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

TravisEz13
Copy link
Member

This pull request includes several changes to the .pipelines/PowerShell-vPack-Official.yml file to improve the handling of package artifacts and validation processes. The most important changes involve setting new package artifact variables, updating paths for artifact listings, and adding error handling for missing files.

Improvements to package artifact handling:

  • Updated the script to set PackageArtifactPath and included the corresponding variable in the pipeline.
  • Changed the path for capturing artifact listings to use PackageArtifactPath instead of System.ArtifactsDirectory.

Validation and error handling enhancements:

  • Added error handling to throw an exception if no packages are found in the specified path.
  • Included a check to ensure that the ob_outputDirectory contains files before proceeding, throwing an error if none are found.

Signing configuration update:

  • Modified the files_to_sign parameter to include only System.Management.Automation.dll instead of all .dll and other file types.

@TravisEz13 TravisEz13 requested a review from Copilot February 11, 2025 20:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@TravisEz13 TravisEz13 marked this pull request as ready for review February 11, 2025 21:16
@TravisEz13 TravisEz13 requested a review from a team as a code owner February 11, 2025 21:16
@TravisEz13
Copy link
Member Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Feb 18, 2025
@TravisEz13 TravisEz13 merged commit 462585a into PowerShell:master Feb 24, 2025
36 checks passed
@TravisEz13 TravisEz13 deleted the fix-vPack branch February 24, 2025 18:30
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 24, 2025

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants