-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Make sure the vPack pipeline does not produce an empty package #24988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
tgauth
approved these changes
Feb 11, 2025
adityapatwardhan
approved these changes
Feb 24, 2025
Contributor
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 24, 2025
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 11, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BackPort-7.4.x-Done
BackPort-7.5.x-Done
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
MustHave
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
.pipelines/PowerShell-vPack-Official.yml
file to improve the handling of package artifacts and validation processes. The most important changes involve setting new package artifact variables, updating paths for artifact listings, and adding error handling for missing files.Improvements to package artifact handling:
PackageArtifactPath
and included the corresponding variable in the pipeline.PackageArtifactPath
instead ofSystem.ArtifactsDirectory
.Validation and error handling enhancements:
ob_outputDirectory
contains files before proceeding, throwing an error if none are found.Signing configuration update:
files_to_sign
parameter to include onlySystem.Management.Automation.dll
instead of all.dll
and other file types.