Filter out the nested modules of PSReadLine from module name tab completion
#24910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs:474
- [nitpick] The variable name 'nestedModulesToFilterOut' is a bit lengthy and could be simplified to 'filteredNestedModules' for better readability.
HashSet<PSModuleInfo> nestedModulesToFilterOut = null;
daxian-dbw
added
the
CL-General
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
iSazonov
reviewed
Feb 1, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Review - Needed
iSazonov
approved these changes
Feb 14, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
microsoft-github-policy-service
bot
removed
the
Review - Needed
iSazonov
approved these changes
Feb 15, 2025
|
📣 Hey @daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When doing module name completion such as
Get-Module mic<tab>orGet-Module psr<tab>, you will seeMicrosoft.PowerShell.PSReadLine2as the result of completion.Microsoft.PowerShell.PSReadLine2is a nested module ofPSReadLine, which shouldn't be returned by completion. It's returned because the completion happens in PSReadLine's context (using PSReadLine'sSessionStateas theEngineSessionState) and hence its nested modules are visible to the tab completion.This PR filters out the nested modules of
PSReadLinefrom the tab completion results. It's intentional to not hard code the name 'PSReadLine' in the change, so that in case the tab completion is triggered from within a different module, its nested modules can also be filtered out.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed: