Allow DSC parsing through OS architecture translation layers #24852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
daxian-dbw
reviewed
Jan 23, 2025
| // Configuration is not supported on ARM64 | ||
| if (PsUtils.IsRunningOnProcessorArchitectureARM()) | ||
| // Configuration is not supported for ARM or ARM64 process architecture. | ||
| if (PsUtils.IsRunningOnProcessArchitectureARM()) |
There was a problem hiding this comment.
@SteveL-MSFT You only mentioned ARM64 not supported in #18781 (comment), not ARM, so should we only check for ARM64 here?
There was a problem hiding this comment.
The configuration keyword is only useful on Windows and Windows only supports Arm64 (no Arm32). However, for the code, it's ok to check for ARM as long as it's a superset of 32 and 64. There should be no functional difference as we don't produce Windows Arm32 packages anymore.
There was a problem hiding this comment.
So, we are good with the current check.
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
bot
added
the
Review - Needed
daxian-dbw
added
the
CL-General
daxian-dbw
approved these changes
Feb 24, 2025
|
📣 Hey @bdeb1337, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
microsoft-github-policy-service
bot
removed
the
Review - Needed
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR replaces the check that restricts parsing DSC configurations when the host OS is of the type ARM.
Instead of checking the host OS, I want to introduce the possibility of checking on process type instead. This way we can allow this for host OS'es that have translation layers to run the x86_64 compiled version of pwsh.
This addresses my issue in #24848 and follows the note/tip of SteveL-MSFT #18781 (comment).
PR Context
I develop DSC(v1) configurations on an ARM mac for use in a windows server environment, and I am currently prohibited of being assisted by the pwsh tooling and interpreter, because the configuration parameter is not "allowed" on ARM hosts.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).