Skip to content

Fix IDisposable implementation in sealed classes #24719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IDisposable implementation in sealed classes #24719

wants to merge 1 commit into from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 29, 2024 •
edited
Loading

  • Do not invoke GC.SuppressFinalize for types without a destructor.
  • Remove redundant void Dispose(bool disposing) method for sealed types.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 2, 2025
@xtqqczze xtqqczze marked this pull request as ready for review January 17, 2025 13:15
@xtqqczze xtqqczze closed this Jan 17, 2025
@xtqqczze xtqqczze reopened this Jan 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jan 25, 2025
@xtqqczze xtqqczze marked this pull request as draft February 1, 2025 18:20
@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 4, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2025
@xtqqczze xtqqczze force-pushed the sealed-dispose branch 2 times, most recently from 4f6d2c7 to b36cecc Compare February 10, 2025 13:18
@xtqqczze xtqqczze marked this pull request as ready for review February 11, 2025 14:43
@xtqqczze
Copy link
Contributor Author

@iSazonov please run CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Review - Needed The PR is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xtqqczze