-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Remove SuppressFinalize
from ClientRemoteSessionDSHandlerImpl
#21218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SuppressFinalize
from ClientRemoteSessionDSHandlerImpl
#21218
Conversation
The motivation of this PR is this comment by @PaulHigin PowerShell#11820 (comment). _Contributes to PowerShell#15110._
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
ClientRemoteSessionDSHandlerImpl
ClientRemoteSessionDSHandlerImpl
src/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.cs
Outdated
Show resolved
Hide resolved
ClientRemoteSessionDSHandlerImpl
SuppressFinalize
from ClientRemoteSessionDSHandlerImpl
📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Follow-up to #24705.
GC.SuppressFinalize
should not be invoked for types without destructors.ClientRemoteSessionDSHandlerImpl
is sealed therefore cannot have a destructor.