-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Option 2 - Change parameter type of -PropertyType
to RegistryValueKind
for New-ItemProperty
#21118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option 2 - Change parameter type of -PropertyType
to RegistryValueKind
for New-ItemProperty
#21118
Conversation
-PropertyType
to RegistryValueKind
for New-ItemProperty
-PropertyType
to RegistryValueKind
for New-ItemProperty
Wondering if we can optimize this by passing in |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Closing in favour of #21117. Added reason in linked issue, happy to reopen this if we have a change of direction and don't want to use argument completer approach 🙂 . |
📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
Fixes #21116
This PR contains the code changes required for Option 2 described in linked issue.
Changed parameter type of
-PropertyType
toRegistryValueKind
forNew-ItemProperty
command.PR Context
This type change enables tab completion automatically on this parameter, instead having to create an argument completer, like in Option 1 implementation #21117.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).