Skip to content

Fix Get-ItemProperty to report non-terminating error for cast exception #21115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ArmaanMcleod
Copy link
Contributor

PR Summary

Fixes #9552

Adds catch for InvalidCastException so non-terminating error gets reported instead of terminating error when listing subkeys with 64 bit integer in 32 bit DWORD.

PR Context

Currently if you do this you get a terminating error for the cast and command is halted. With this exception handling we can now get non-terminating error and also suppress error with -ErrorAction SilentlyContinue. Get-ItemProperty will continue to enumerate subkeys even if an invalid one is found.

PR Checklist

@iSazonov
Copy link
Collaborator

@ArmaanMcleod We need to skip new test code on Windows.

@ArmaanMcleod
Copy link
Contributor Author

ArmaanMcleod commented Jan 20, 2024

@iSazonov Do you mean we should skip if not windows and powershell core? Makes sense if this is for new test it should only work for powershell core on windows.

I've added conditions to lock tests to windows only.

@iSazonov iSazonov added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update labels Jan 21, 2024

This PR has 36 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +34 -2
Percentile : 14.4%

Total files changed: 2

Change summary by file extension:
.cs : +9 -2
.ps1 : +25 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jan 28, 2024
@iSazonov iSazonov merged commit b5fbe9e into PowerShell:master Dec 27, 2024
38 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Dec 27, 2024

📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Dec 27, 2024
@ArmaanMcleod ArmaanMcleod deleted the fix-get-item-property-command-invalid-cast branch December 27, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-itemproperty : Unable to cast object of type 'System.Int64' to type 'System.Int32' (Specified cast is not valid).
2 participants