Changes to export PostHistory and Comments data files to PostGres database #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| parser.add_argument( '-p', '--password' | ||
| , help = 'Password for the database.' | ||
| , default = None | ||
| , default = 'fibinse' |
| FROM accepted_answer_id | ||
| ) | ||
|
|
||
| AND p.acceptedanswerid=h.postid; |
There was a problem hiding this comment.
This feels a bit too ad-hoc to be part of the default tables to be created. Perhaps this could be put in optional_post.sql?
There was a problem hiding this comment.
If you think it is still valuable, create a new PR with a short comment about its importance and change the names of the fields to conform with the other tables. It is unfortunate that the names are case insensitive, but it is better to be consistent now rather than making the user guess the field names per table.
| @@ -0,0 +1,9 @@ | |||
| DROP TABLE IF EXISTS Tags CASCADE; | |||
There was a problem hiding this comment.
This is a typo, it should be Comments instead. I'll fix it before merging it.
|
Sorry for not getting to it earlier. I'm about to merge it in with some minor changes. |
musically-ut
added a commit
that referenced
this pull request
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.