Skip to content

fix(ios) Update Podfile dependencies #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2020
Merged

fix(ios) Update Podfile dependencies #329

merged 2 commits into from
Aug 2, 2020

Conversation

ridcully
Copy link
Contributor

@ridcully ridcully commented Jul 6, 2020

PR Checklist

What is the current behavior?

nativescript-imagepicker and nativescript-camera-plus do not work together.

What is the new behavior?

Using the same QBImagePickerController dependency as nativescript-camera-plus plugin does.

Fixes #328 and nstudio/nativescript-camera-plus#132.

ridcully added 2 commits July 6, 2020 14:52
Using the same QBImagePickerController dependency as nativescript-camera-plus plugin does.
@cla-bot
Copy link

cla-bot bot commented Jul 6, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @ridcully.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ridcully ridcully changed the title Update Podfile dependencies fix(ios) Update Podfile dependencies Jul 6, 2020
@ridcully
Copy link
Contributor Author

ridcully commented Jul 6, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jul 6, 2020
@cla-bot
Copy link

cla-bot bot commented Jul 6, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker NathanWalker merged commit 72c4d05 into NativeScript:master Aug 2, 2020
@NathanWalker
Copy link
Contributor

Thank you @ridcully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IOS]multiple dependencies with different sources for QBImagePickerController issue when install with @nstudio/nativescript-camera-plus
2 participants