chore(core): Got rid of setNative type errors #10768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new behavior?
This PR gets rid of type errors related to some computed
setNative
methods.Since we use symbols to define methods with a single argument, TypeScript may complain about union string types for prototype's
[prop: symbol]
.Things can get a bad turn if some methods use
any
as an argument type or unions/enums end up in conflict with string type.To solve this, the following actions have been performed:
any
with the corresponding typeA small example to understand the conflict:
And this will work because TS doesn't know about expected string argument yet.