Skip to content

feat(android): allow transparent modal backgrounds #10761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(android): allow transparent modal backgrounds #10761

wants to merge 1 commit into from

Conversation

SeanKelly369
Copy link

For the modal dialogs, this removes the white with shape edges that can appear when a modal with radiused borders is used.

BREAKING CHANGES: Dialogs with no background colour set may become transparent.

Tests run forked repository all passed

An example app showing the changes can be accessed at https://github.com/SeanKelly369/native_dialog_tut

Presidents_modal_android

@SeanKelly369
Update index.android.ts
79d3ec3 
For the modal dialogs, this removes the white with shape edges that can appear when a modal with radiused borders is used.
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NathanWalker NathanWalker changed the title Update index.android.ts feat(android): allow transparent modal backgrounds Jul 11, 2025
@CatchABus
Copy link
Contributor

@SeanKelly369 This might need some extra work as core enforces white color for fullscreen modals here: https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/core/view/index.android.ts#L255

Also, this should fix/close #10360

@SeanKelly369
Copy link
Author

@CatchABus What do you propose should be done? As is, having that white background is a problem in dialogs for Android.

@CatchABus
Copy link
Contributor

@CatchABus What do you propose should be done? As is, having that white background is a problem in dialogs for Android.

Yes, indeed.
We might need a mid-solution. Like keeping color for fullscreen modals and make other modals transparent. 🤔

@SeanKelly369
Copy link
Author

@CatchABus That's work alright

@CatchABus
Copy link
Contributor

CatchABus commented Jul 21, 2025 •
edited
Loading

@CatchABus That's work alright

There's still this case that worries me.

BREAKING CHANGES: Dialogs with no background colour set may become transparent.

This is a personal opinion but how does having an android-specific property for changing window color sound?
We have already got platform-specific props like iOS presentationStyle.

So, your example would look like this.

        const modalOptions: NativeDialogConfig = {
            data: this.president,
            nativeOptions: {
                fullscreen: true,
                animated: false,
                android: {
                    windowBackgroundColor: 'transparent'
                },
                ios: {
                    presentationStyle: UIModalPresentationStyle.OverCurrentContext
                }
            }
        };

@SeanKelly369
Copy link
Author

@CatchABus Your concern is a valid one and I think your solution proposal is a good one.

@CatchABus
Copy link
Contributor

@CatchABus Your concern is a valid one and I think your solution proposal is a good one.

Thanks! If you feel like it, you could continue with this idea here in this PR or maybe one of us could work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanKelly369 @CatchABus