Skip to content

fixed broken links for code examples #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vedmin
Copy link

@vedmin vedmin commented Nov 28, 2022

Fixed broken links for code examples of asynchronous operations in C++.

Fixed broken links for code examples of asynchronous operations in C++.
@prmerger-automator
Copy link
Contributor

@vedmin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld30
Copy link

opbld30 commented Nov 28, 2022

Learn Build status updates of commit c19e954:

✅ Validation status: passed

File Status Preview URL Details
docs/parallel/concrt/creating-asynchronous-operations-in-cpp-for-windows-store-apps.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Nov 28, 2022

@TylerMSFT

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 28, 2022
@TylerMSFT
Copy link
Collaborator

@vedmin, Hi, thank you for caring about the docs. I'm puzzled by the change because our filesystem isn't case-sensitive and I don't see a problem with the existing links. Can you explain what you are seeing that led you to make these changes?

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, these changes aren't necessary. The links aren't case-sensitive and we use lowercase.

@TylerMSFT
Copy link
Collaborator

Asked for clarification in November, but didn't hear back. I don't believe this change is necessary.

@TylerMSFT TylerMSFT closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants