Fixed __vmx_on parameter being incorrect #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the intel manual Vol. 3C 30-27, "The operand of this instruction is a 4KB-aligned physical address (the VMXON pointer) that references the VMXON region, which the logical processor may use to support VMX operation. This operand is always 64 bits and is always in memory.". this was already correctly explained in the "Parameters" section, but also wrongly named.
|
@sariaki : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@corob-msft - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a Thanks! #label:"aq-pr-triaged" |
|
@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
colin-home
approved these changes
May 16, 2022
There was a problem hiding this comment.
@sariaki
Thanks for the update. I wouldn't go so far as to say the existing (and entirely arbitrary) name was wrong in terms of describing the purpose of the region, but if you're trying for a maximally literal meaning, this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the intel manual Vol. 3C 30-27: "The operand of this instruction is a 4KB-aligned physical address (the VMXON pointer) that references the VMXON region, which the logical processor may use to support VMX operation. This operand is always 64 bits and is always in memory".
this was already correctly explained in the "Parameters" section, but was wrongly named.