Skip to content

Build testing #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

Build testing #89

wants to merge 60 commits into from

Conversation

jake-perkins
Copy link
Contributor

No description provided.

cursor[bot]
cursor bot reviewed Jul 17, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redundant Secret Name Input

The secret-name input is defined as required but is never used. The action instead determines the secret name based on the environment input, making the secret-name input redundant and confusing.

.github/actions/configure-keystore/action.yml#L10-L13

github-tools/.github/actions/configure-keystore/action.yml

Lines 10 to 13 in 6a7e3cd

required: true
secret-name:
description: "The name of the secret in AWS Secrets Manager"
required: true

Fix in Cursor • Fix in Web

Bug: Shell Parsing Error and Missing Expression Syntax

The for key in $keys loop in the "Fetch secret and export as environment variables" step is vulnerable to shell word splitting, which will incorrectly parse JSON keys containing spaces or special characters. Additionally, the if condition for the "Configure Android Keystore" step (if: inputs.platform == 'android') is missing the required ${{ }} expression syntax.

.github/actions/configure-keystore/action.yml#L59-L69

github-tools/.github/actions/configure-keystore/action.yml

Lines 59 to 69 in 6a7e3cd

keys=$(echo "$secret_json" | jq -r 'keys[]')
for key in $keys; do
value=$(echo "$secret_json" | jq -r --arg k "$key" '.[$k]')
echo "::add-mask::$value"
echo "$key=$(printf '%s' "$value")" >> "$GITHUB_ENV"
echo "✅ Set secret for key: $key"
done
- name: Configure Android Keystore
if: inputs.platform == 'android'

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team-dev-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jake-perkins @metamaskbot @makemesteaks