Skip to content

Emulator configs #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 18, 2025
Merged

Emulator configs #88

merged 7 commits into from
Jul 18, 2025

Conversation

makemesteaks
Copy link
Member

No description provided.

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@makemesteaks makemesteaks changed the base branch from main to e2e-env-actions July 18, 2025 15:14
cursor[bot]
cursor bot reviewed Jul 18, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Setup-Simulator Misleading and Ineffective

The setup-simulator input parameter is misleading: while its description implies setting up and booting simulators/emulators, the corresponding logic has been removed. Specifically, for iOS, simulator booting was replaced by just listing devices, and for Android, emulator launch and boot-waiting steps were removed. As a result, setting setup-simulator: true no longer starts a simulator or emulator, causing E2E tests to fail. The parameter also now controls unrelated steps (e.g., iOS CocoaPods installation), further confusing its purpose.

.github/actions/setup-e2e-env/action.yml#L14-L18

github-tools/.github/actions/setup-e2e-env/action.yml

Lines 14 to 18 in be4eab0

default: '1.22.22'
setup-simulator:
description: 'Whether to setup simulator/emulator'
required: false
default: 'false'

.github/actions/setup-e2e-env/action.yml#L211-L215

github-tools/.github/actions/setup-e2e-env/action.yml

Lines 211 to 215 in be4eab0

- name: Check simutils
if: ${{ inputs.platform == 'ios' }}
run: xcrun simctl list devices
shell: bash

.github/actions/setup-e2e-env/action.yml#L318-L328

github-tools/.github/actions/setup-e2e-env/action.yml

Lines 318 to 328 in be4eab0

- name: Create Android Virtual Device (AVD)
if: ${{ inputs.platform == 'android'}}
run: |
IMAGE="system-images;android-${{ inputs.android-api-level }};google_apis;${{ inputs.android-abi }}"
echo "Creating AVD with image: $IMAGE"
echo "no" | "${ANDROID_HOME}/cmdline-tools/latest/bin/avdmanager" create avd \
--name "${{ inputs.android-avd-name }}" \
--package "$IMAGE" \
--device "${{ inputs.android-device }}"
shell: bash

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@makemesteaks makemesteaks merged commit a3cd1cb into e2e-env-actions Jul 18, 2025
17 of 19 checks passed
@makemesteaks makemesteaks deleted the emulator-configs branch July 18, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@jake-perkins jake-perkins jake-perkins approved these changes

Assignees
No one assigned
Labels
team-dev-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makemesteaks @jake-perkins @metamaskbot