feat: add workflow to upload Yarn binary to GitHub Release #74

Qbandev · 2025-06-10T09:47:50Z

What is the current state of things and why does it need to change?

Currently, there is no automated way to upload Yarn binaries to GitHub Releases in this repository. This is needed to provide a reliable, rate-limit-free, and cost-effective way for CI pipelines and other consumers to fetch specific Yarn versions.

What is the solution your changes offer and how does it work?

This PR introduces a new GitHub Actions workflow (.github/workflows/upload-yarn-binary.yml) that allows maintainers to manually upload a specific Yarn version (e.g., 4.9.1) as a release asset. The workflow:

Accepts a Yarn version as input.
Downloads the corresponding yarn.js binary.
Creates or updates a GitHub Release for that version.
Uploads the binary as a release asset.
Outputs the download URL for use in CI or documentation.

Are there any issues or other links reviewers should consult to understand this pull request better?

See: INFRA-2575

jluque0101 · 2025-06-10T10:41:28Z

@Qbandev is there a test where we can see this workflow in action?

jluque0101 · 2025-06-10T10:42:35Z

.github/workflows/upload-yarn-binary.yml

+          curl -L -o "$YARN_FILENAME" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"
+          ls -lh "$YARN_FILENAME"
+
+      - name: Display SHA256 checksum


what is the purpose of the showing the checksum, would be worth comparing it with the expected one if happens that you can fetch it once the download is completed?

My idea was to check if we can use that checksum in the URL

Qbandev · 2025-06-10T13:15:25Z

@Qbandev is there a test where we can see this workflow in action?

@jluque0101 You can see a test here https://github.com/Qbandev/github-tools/actions/runs/15560468684/job/43811216486
And here the custom yarn-url MetaMask/metamask-extension#33562 being used

itsyoboieltr · 2025-06-10T16:03:10Z

.github/workflows/upload-yarn-binary.yml

+            echo "YARN_VERSION=${{ github.event.inputs.yarn_version }}"
+            echo "YARN_FILENAME=yarn-${{ github.event.inputs.yarn_version }}.js"
+            echo "RELEASE_TAG=v${{ github.event.inputs.yarn_version }}"
+          } >> "$GITHUB_ENV"


This does not need to be a separate step. You can add in to the env key of the job.

itsyoboieltr · 2025-06-10T16:03:34Z

.github/workflows/upload-yarn-binary.yml

+
+      - name: Download yarn.js binary
+        run: |
+          curl -L -o "$YARN_FILENAME" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"


Suggested change

curl -L -o "$YARN_FILENAME" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"

curl -L -o "${YARN_FILENAME}" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"

itsyoboieltr · 2025-06-10T16:03:45Z

.github/workflows/upload-yarn-binary.yml

+      - name: Download yarn.js binary
+        run: |
+          curl -L -o "$YARN_FILENAME" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"
+          ls -lh "$YARN_FILENAME"


Suggested change

ls -lh "$YARN_FILENAME"

ls -lh "${YARN_FILENAME}"

itsyoboieltr · 2025-06-10T16:04:10Z

.github/workflows/upload-yarn-binary.yml

+
+      - name: Display SHA256 checksum
+        run: |
+          sha256sum "$YARN_FILENAME"


Suggested change

sha256sum "$YARN_FILENAME"

sha256sum "${YARN_FILENAME}"

itsyoboieltr · 2025-06-10T16:04:47Z

.github/workflows/upload-yarn-binary.yml

+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          # Create the release if it doesn't exist
+          gh release view "$RELEASE_TAG" || gh release create "$RELEASE_TAG" --title "Yarn $YARN_VERSION" --notes "Yarn CLI $YARN_VERSION binary."


Suggested change

gh release view "$RELEASE_TAG" || gh release create "$RELEASE_TAG" --title "Yarn $YARN_VERSION" --notes "Yarn CLI $YARN_VERSION binary."

gh release view "${RELEASE_TAG}" || gh release create "${RELEASE_TAG}" --title "Yarn ${YARN_VERSION}" --notes "Yarn CLI ${YARN_VERSION} binary."

itsyoboieltr · 2025-06-10T16:05:16Z

.github/workflows/upload-yarn-binary.yml

+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh release upload "$RELEASE_TAG" "$YARN_FILENAME" --clobber


Suggested change

gh release upload "$RELEASE_TAG" "$YARN_FILENAME" --clobber

gh release upload "${RELEASE_TAG}" "${YARN_FILENAME}" --clobber

itsyoboieltr · 2025-06-10T16:06:15Z

.github/workflows/upload-yarn-binary.yml

+      - name: Output download URL
+        id: output-url
+        run: |
+          url="https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"


Suggested change

url="https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"

url="https://github.com/${GITHUB_REPOSITORY}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"

itsyoboieltr · 2025-06-10T16:06:33Z

.github/workflows/upload-yarn-binary.yml

+        id: output-url
+        run: |
+          url="https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"
+          echo "Download URL: $url"


Suggested change

echo "Download URL: $url"

echo "Download URL: ${url}"

itsyoboieltr · 2025-06-10T16:06:53Z

.github/workflows/upload-yarn-binary.yml

+        run: |
+          url="https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"
+          echo "Download URL: $url"
+          echo "download_url=$url" >> "$GITHUB_OUTPUT"


Suggested change

echo "download_url=$url" >> "$GITHUB_OUTPUT"

echo "download_url=${url}" >> "${GITHUB_OUTPUT}"

Copilot

Pull Request Overview

Adds a manual GitHub Actions workflow to download a specified Yarn CLI binary and upload it as a GitHub Release asset, then outputs its download URL.

Introduces .github/workflows/upload-yarn-binary.yml triggered via workflow_dispatch with a yarn_version input.
Downloads yarn.js, computes its SHA256 checksum, creates or updates the corresponding release tag, uploads the binary, and exposes the download URL.
Grants necessary write permissions and exposes the URL as a job output.

Comments suppressed due to low confidence (2)

.github/workflows/upload-yarn-binary.yml:29

Use curl's -f flag (e.g., curl -fSL) to ensure the step fails on HTTP errors (like 404), otherwise curl may download an HTML error page and subsequent steps would run against an invalid file.

curl -L -o "${YARN_FILENAME}" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"

.github/workflows/upload-yarn-binary.yml:24

[nitpick] The checkout step isn’t used in any following steps—consider removing it to reduce workflow runtime.

- name: Checkout repository

Copilot · 2025-06-10T19:00:55Z

.github/workflows/upload-yarn-binary.yml

@@ -0,0 +1,53 @@
+name: Upload Yarn Binary to GitHub Release


[nitpick] Consider adding a concurrency group to prevent multiple manual dispatches from clobbering the same release simultaneously, for example:

concurrency: group: upload-yarn-binary-${{ github.event.inputs.yarn_version }} cancel-in-progress: false

feat: add upload-yarn-binary workflow

a92f16b

Qbandev requested a review from Copilot June 10, 2025 09:50

This comment was marked as outdated.

Sign in to view

Qbandev added enhancement New feature or request team-dev-ops labels Jun 10, 2025

fix: add lint and remove gh installation

b20a5e9

Qbandev requested a review from Copilot June 10, 2025 09:55

This comment was marked as outdated.

Sign in to view

fix: add yarn url to output

5936b7b

Qbandev requested a review from Copilot June 10, 2025 10:04

This comment was marked as outdated.

Sign in to view

alucardzom previously approved these changes Jun 10, 2025

View reviewed changes

Qbandev requested review from bsuv, HowardBraham, itsyoboieltr and jake-perkins June 10, 2025 10:22

jluque0101 previously approved these changes Jun 10, 2025

View reviewed changes

jluque0101 reviewed Jun 10, 2025

View reviewed changes

fix: add checkout step

df7148d

Qbandev dismissed stale reviews from jluque0101 and alucardzom via df7148d June 10, 2025 13:11

Qbandev requested review from alucardzom, jluque0101 and Copilot June 10, 2025 13:14

This comment was marked as outdated.

Sign in to view

jluque0101 previously approved these changes Jun 10, 2025

View reviewed changes

alucardzom previously approved these changes Jun 10, 2025

View reviewed changes

itsyoboieltr requested changes Jun 10, 2025

View reviewed changes

fix: apply changes suggested

2ef7408

Qbandev dismissed stale reviews from alucardzom and jluque0101 via 2ef7408 June 10, 2025 18:58

Qbandev requested a review from Copilot June 10, 2025 18:58

Copilot AI reviewed Jun 10, 2025

View reviewed changes

itsyoboieltr approved these changes Jun 10, 2025

View reviewed changes

Qbandev merged commit 1c38c80 into main Jun 10, 2025
18 checks passed

Qbandev deleted the feat-github-release branch June 10, 2025 19:35

	curl -L -o "$YARN_FILENAME" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"
	curl -L -o "${YARN_FILENAME}" "https://repo.yarnpkg.com/${YARN_VERSION}/packages/yarnpkg-cli/bin/yarn.js"

	gh release view "$RELEASE_TAG" \|\| gh release create "$RELEASE_TAG" --title "Yarn $YARN_VERSION" --notes "Yarn CLI $YARN_VERSION binary."
	gh release view "${RELEASE_TAG}" \|\| gh release create "${RELEASE_TAG}" --title "Yarn ${YARN_VERSION}" --notes "Yarn CLI ${YARN_VERSION} binary."

	gh release upload "$RELEASE_TAG" "$YARN_FILENAME" --clobber
	gh release upload "${RELEASE_TAG}" "${YARN_FILENAME}" --clobber

	url="https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"
	url="https://github.com/${GITHUB_REPOSITORY}/releases/download/${RELEASE_TAG}/${YARN_FILENAME}"

	echo "download_url=$url" >> "$GITHUB_OUTPUT"
	echo "download_url=${url}" >> "${GITHUB_OUTPUT}"

Uh oh!

feat: add workflow to upload Yarn binary to GitHub Release #74

feat: add workflow to upload Yarn binary to GitHub Release #74

Uh oh!

Conversation

Qbandev commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

jluque0101 commented Jun 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Qbandev commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Qbandev commented Jun 10, 2025 •

edited

Loading

Qbandev commented Jun 10, 2025 •

edited

Loading