Skip to content

Add GCF bearer token sample #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 8, 2020
Merged

Add GCF bearer token sample #3277

merged 5 commits into from
Apr 8, 2020

Conversation

ace-n
Copy link

@ace-n ace-n commented Apr 3, 2020 •
edited
Loading

N.B: this sample is both simple and hard to (properly) test, so I didn't include tests here.

(Properly testing it would likely require deploying it to GCF itself.)

@ace-n ace-n requested review from grant and a team as code owners April 3, 2020 19:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2020
@ace-n ace-n assigned grant and unassigned gguuss Apr 4, 2020
grant
grant approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read comments and make changes before merging.

gguuss
gguuss approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw nits

@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Apr 8, 2020
@ace-n ace-n merged commit 35ded53 into master Apr 8, 2020
@anguillanneuf anguillanneuf deleted the bearer-auth branch November 3, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

@gguuss gguuss gguuss approved these changes

Assignees

@grant grant

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @grant @gguuss @googlebot