Skip to content

fix: increase start delay for ASGI conformance tests to address flaky failures #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: increase start delay for ASGI conformance tests to address flaky failures #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/conformance-asgi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
useBuildpacks: false
validateMapping: false
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_http --signature-type http --asgi'"
startDelay: 5

- name: Run CloudEvents conformance tests
uses: GoogleCloudPlatform/functions-framework-conformance/action@72a4f36b10f1c6435ab1a86a9ea24bda464cc262 # v1.8.6
Expand All @@ -62,6 +63,7 @@ jobs:
useBuildpacks: false
validateMapping: false
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_cloud_event --signature-type cloudevent --asgi'"
startDelay: 5

- name: Run HTTP conformance tests declarative
uses: GoogleCloudPlatform/functions-framework-conformance/action@72a4f36b10f1c6435ab1a86a9ea24bda464cc262 # v1.8.6
Expand All @@ -70,6 +72,7 @@ jobs:
useBuildpacks: false
validateMapping: false
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_http_declarative --asgi'"
startDelay: 5

- name: Run CloudEvents conformance tests declarative
uses: GoogleCloudPlatform/functions-framework-conformance/action@72a4f36b10f1c6435ab1a86a9ea24bda464cc262 # v1.8.6
Expand All @@ -78,6 +81,7 @@ jobs:
useBuildpacks: false
validateMapping: false
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_cloud_event_declarative --asgi'"
startDelay: 5

- name: Run HTTP concurrency tests declarative
uses: GoogleCloudPlatform/functions-framework-conformance/action@72a4f36b10f1c6435ab1a86a9ea24bda464cc262 # v1.8.6
Expand All @@ -86,6 +90,7 @@ jobs:
useBuildpacks: false
validateConcurrency: true
cmd: "'functions-framework --source tests/conformance/async_main.py --target write_http_declarative_concurrent --asgi'"
startDelay: 5

# Note: Event (legacy) and Typed tests are not supported in ASGI mode
# Note: validateMapping is set to false for CloudEvent tests because ASGI mode
Expand Down
Loading