fix: remove unused httpx dependency #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpx was accidentally added in GoogleCloudPlatform#364 but is not used anywhere in the codebase. Removing it reduces our dependency count from 28 to 20 packages. Impact: - Removes 8 unnecessary packages (httpx + 7 transitive deps) - Reduces installation size by ~2MB - Keeps only the actually needed async dependencies
akerekes
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
httpxdependency that was accidentally added in #364 but is never used in the codebase.Context
While investigating our dependency growth, I discovered that
httpxwas added as a direct dependency but is not imported or used anywhere in the functions-framework codebase. This single dependency brought in 7 additional transitive dependencies.Impact
Before this PR (28 packages):
After this PR (20 packages):
Dependency Analysis
From the last release to current:
With this fix, we're back to the expected 20 packages (17 + 3 async).
Test Plan
All existing tests pass. The httpx package was never used, so its removal has no functional impact.