refactor: move async dependencies from optional to direct #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on dependency analysis, adding starlette, uvicorn, and uvicorn-worker as direct dependencies only increases installation size by ~816KB (3.5%). This minimal impact makes it reasonable to include them directly, simplifying installation for users who need async functionality while maintaining Python 3.8+ compatibility constraints.
…dencies - Remove async extras from tox.ini since deps are now direct - Update _http/__init__.py to import StarletteApplication directly - Remove try/except ImportError for starlette in aio/__init__.py - Remove error message about installing with [async] extra - Update test_asgi.py to import starlette directly - Remove test_import_error_without_starlette from test_aio.py - Fix test_http.py monkeypatch to work with direct imports
…sk apps Reverts the direct import of StarletteApplication to keep it as a dynamic import. This ensures that Flask-only users don't load the asgi module and its starlette/uvicorn dependencies unnecessarily.
Since async dependencies are now direct dependencies, we no longer need to install with [async] extras in the GitHub workflow.
maemayve
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves starlette, uvicorn, and uvicorn-worker from optional dependencies to direct dependencies, simplifying the installation process for users who need async functionality.
Impact Analysis
pip install functions-framework[async]Changes
pyproject.toml[async]extra dependency configurationTest Plan
All existing tests pass with 100% coverage. The async functionality remains unchanged, just the installation method is simplified.