fix: set ASGI logging level to WARNING to match WSGI behavior #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabled When LOG_EXECUTION_ID is enabled, the WSGI implementation was setting the root logger to WARNING level, which silenced info-level logs. This was inconsistent with: - The ASGI implementation which correctly uses INFO level - The default setup_logging() function which also uses INFO level This change ensures that logger.info() calls are visible in both WSGI and ASGI stacks when execution ID logging is enabled.
taeold
changed the title
|
Oh interesting. This directly conflicts w/ #336 |
|
Reported in #337 |
taeold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASGI logger defaults to
INFOinstead ofWARNINGwhich is the default for Python.