Skip to content

feat: allow for watchdog>=2.0.0 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2022
Merged

feat: allow for watchdog>=2.0.0 #186

merged 3 commits into from
May 18, 2022

Conversation

MichaelKarpe
Copy link
Contributor

@MichaelKarpe MichaelKarpe commented May 3, 2022

mkdocs>=1.2.2 depends on watchdog>=2.0 and the restriction of watchdog dependency for functions-framework-python done in #101 seems to be due an issue related to watchdog built distributions (as explained by @di) which is now fixed.

I propose to allow for watchdog>=2.0.0 so that a project can use both mkdocs>=1.2.2 (or watchdog>=2.0.0) and functions-framework-python>=3.0.0.

@grant grant added the automerge Summon MOG for automerging label May 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b4ed666 into GoogleCloudPlatform:master May 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label May 18, 2022
@MichaelKarpe MichaelKarpe deleted the watchdog-requirement branch July 21, 2022 16:18
@HKWinterhalter HKWinterhalter mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants