Skip to content

chore: Pre-release version 2.4.0-beta.2 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2021
Merged

chore: Pre-release version 2.4.0-beta.2 #164

merged 4 commits into from
Nov 1, 2021

Conversation

KaylaNguyen
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 30, 2021
@KaylaNguyen KaylaNguyen requested a review from grant October 30, 2021 01:31
@KaylaNguyen KaylaNguyen requested a review from anniefu November 1, 2021 21:27
grant
grant suggested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm unsure if we want to delete the beta.1 release
  • nit: I believe these commits should be in the type chore, as in chore: Pre-release version 2.4.0-beta.2 as to not produce a change in semver.

@KaylaNguyen KaylaNguyen changed the title feat: Pre-release version 2.4.0-beta.2 chore: Pre-release version 2.4.0-beta.2 Nov 1, 2021
@KaylaNguyen KaylaNguyen requested a review from grant November 1, 2021 22:15
grant
grant approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@KaylaNguyen KaylaNguyen merged commit 75cc22c into GoogleCloudPlatform:master Nov 1, 2021
KaylaNguyen added a commit to KaylaNguyen/functions-framework-python that referenced this pull request Nov 2, 2021
@KaylaNguyen
chore: Pre-release version 2.4.0-beta.2 (GoogleCloudPlatform#164)
1990c8b
@KaylaNguyen KaylaNguyen deleted the version-v2.4.0-beta.2 branch November 12, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

@anniefu anniefu Awaiting requested review from anniefu

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaylaNguyen @grant