Skip to content

feat: implement storage_system_test example #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2021
Merged

feat: implement storage_system_test example #276

merged 3 commits into from
Feb 19, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 19, 2021

Fixes #100

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2021
@snippet-bot
Copy link

snippet-bot bot commented Feb 19, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Feb 19, 2021 •
edited
Loading

Codecov Report

Merging #276 (c2b81b5) into main (d0fe67b) will decrease coverage by 1.79%.
The diff coverage is 25.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   90.19%   88.40%   -1.80%     
==========================================
  Files          82       84       +2     
  Lines        2080     2138      +58     
==========================================
+ Hits         1876     1890      +14     
- Misses        204      248      +44
Impacted Files Coverage Δ
examples/site/hello_world_get/hello_world_get.cc 100.00% <ø> (ø)
...amples/site/testing_storage/storage_system_test.cc 0.00% <0.00%> (ø)
...es/site/hello_world_storage/hello_world_storage.cc 100.00% <100.00%> (ø)
examples/site/log_helloworld/log_helloworld.cc 100.00% <100.00%> (ø)
examples/site_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fe67b...c393fd2. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 19, 2021 12:32
@coryan coryan requested a review from a team as a code owner February 19, 2021 12:32
@coryan
Copy link
Contributor Author

coryan commented Feb 19, 2021

I do not know how to avoid the code coverage hit, so we will have to take it.

devbww
devbww approved these changes Feb 19, 2021
View reviewed changes
@coryan coryan merged commit fc7ef30 into GoogleCloudPlatform:main Feb 19, 2021
@coryan coryan deleted the feat-add-storage_system_test-example branch February 19, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement example: functions_storage_system_test
2 participants
@coryan @devbww