Skip to content

generate header id the same as github #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

generate header id the same as github #303

wants to merge 1 commit into from

Conversation

livelazily
Copy link

for example:

Original marked:

var marked = require('marked');

var input = '### CollectionView\'s `getItemView`';

console.log(marked.parse(input));
//=> <h3 id="collectionview-s-getitemview-">CollectionView&#39;s <code>getItemView</code></h3>

the h3's id is collectionview-s-getitemview-

but in github, the id is collectionviews-getitemview
github just ignore all non word characters

@SamyPesse
Copy link
Member

Sorry for taking so long, can you rebase on master so that we can merge it.

@SamyPesse SamyPesse closed this in 82f814f Jul 12, 2014
@OriPekelman OriPekelman mentioned this pull request Nov 30, 2023
Open
@GerHobbelt GerHobbelt mentioned this pull request Nov 30, 2023
Open
@piranna piranna mentioned this pull request Dec 6, 2023
Open
SamyPesse added a commit that referenced this pull request Mar 24, 2024
@SamyPesse @gregberge
Fallback to MathJax when KaTeX fails to compile math (#303)
cf958ba 
* Start

* Use MathJax v3

* Format

* Improve font-size

* Lint

* Better handle loading

* Copy MathJax assets to public folder

* Attempt at using local assets for MathJax

* Use bun 1.0.31

* Try with bun 1.0.33

* Try fixing headers

* Simplify

* Simplify and not use suspense module

* Cleanup more

* Add test for Math

* Make math block scroll if needed

* Update packages/react-math/src/KaTeX.tsx

Co-authored-by: Greg Bergé <berge.greg@gmail.com>

* Use React.use

* Format

* Use exports

* Lint

* Disable cache in CI for lint

* Format

---------

Co-authored-by: Greg Bergé <berge.greg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@livelazily @SamyPesse