Merge pull request github-tools#13 from mattpass/master

michael · michael · commit 5e8ac76bb81a · 2012-07-24T10:49:45.000-07:00
Avoiding callback errors
diff --git a/github.js b/github.js
@@ -20,7 +20,7 @@
       xhr.onreadystatechange = function () {
         if (this.readyState == 4) {
           if (this.status >= 200 && this.status < 300 || this.status === 304) {
-            cb(null, raw ? this.responseText : JSON.parse(this.responseText));
+            cb(null, raw ? this.responseText : this.responseText ? JSON.parse(this.responseText) : true);
           } else {
             cb(this.status);
           }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`xhr.onreadystatechange = function () {`
`21`	`21`	`if (this.readyState == 4) {`
`22`	`22`	`if (this.status >= 200 && this.status < 300 \|\| this.status === 304) {`
`23`		`- cb(null, raw ? this.responseText : JSON.parse(this.responseText));`
	`23`	`+ cb(null, raw ? this.responseText : this.responseText ? JSON.parse(this.responseText) : true);`
`24`	`24`	`} else {`
`25`	`25`	`cb(this.status);`
`26`	`26`	`}`